Fix tests due to Node.js changing the JSON.parse error messages #635
Conversation
| (error) => { | ||
| assert.strictEqual( | ||
| error.message.replace( | ||
| // Handle slightly different JSON.parse error messages on different Node.js versions. | ||
| /^.+ in JSON at position .+$/gm, | ||
| '(the JSON parse error)' | ||
| ), | ||
| expected | ||
| ); | ||
| return true; |
There was a problem hiding this comment.
You can pass an assertion there 🤦♂️
Now that makes sense.
There was a problem hiding this comment.
Yeah, I had to look that up the docs and play around with it in my editor. Otherwise I would have left a comment on your PR. Hope that’s ok 😄
This turned out to be difficult to merge anyway due to other things being out of date, and me trying to ambitious and not just do the simplest fix…
There was a problem hiding this comment.
Yeah, I had to look that up the docs and play around with it in my editor. Otherwise I would have left a comment on your PR. Hope that’s ok 😄
That's fine 😁
This turned out to be difficult to merge anyway due to other things being out of date, and me trying to ambitious not just do the simplest fix…
I'd be the same way 😅
Fixes #633.
Closes #634.
CI failed, due to the test matrix, so updated that too. Then macOS-latest required elm-tooling and elm-json to be updated.